Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix export tutorial #3130

Open
wants to merge 9 commits into
base: 2.6-RC-TEST
Choose a base branch
from
Open

Fix export tutorial #3130

wants to merge 9 commits into from
+193 −203

Conversation

angelayi
Copy link
Contributor

Fixing issues from @lucylq (thanks!)

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3130

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5bc8a58 with merge base 20c3111 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@angelayi angelayi force-pushed the angelayi/export_fix branch from 3463b49 to 74715d4 Compare October 30, 2024 18:23
@svekars
Copy link
Contributor

svekars commented Oct 30, 2024

I believe we need to enable here: https://github.com/pytorch/tutorials/blob/main/.jenkins/validate_tutorials_built.py#L52

@angelayi angelayi force-pushed the angelayi/export_fix branch from 74715d4 to c371b99 Compare October 30, 2024 23:20
@angelayi angelayi requested a review from svekars October 31, 2024 17:06
HanBnrd and others added 2 commits December 20, 2024 08:01
@HanBnrd
Remove Tensor.data attribute from tutorial (#3193)
2793639
@janeyx99
Mention Python agnosticism in custom ops tutorial (#3204)
6f54c88 
* Mention Python agnosticism in custom ops tutorial

* light dusting on grammar

* be explicit
@github-actions GitHub Actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as stale.
Feel free to remove the stale label if you feel this was a mistake.
If you are unable to remove the stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale Stale PRs label Dec 31, 2024
@angelayi angelayi force-pushed the angelayi/export_fix branch 2 times, most recently from fb33df2 to 351e0e1 Compare January 6, 2025 17:59
@angelayi angelayi force-pushed the angelayi/export_fix branch from 351e0e1 to 200c594 Compare January 6, 2025 18:14
angelayi
angelayi commented Jan 6, 2025
View reviewed changes
intermediate_source/torch_export_tutorial.py
######################################################################
# Other control flow ops include ``while_loop``, ``associative_scan``, and
# ``scan``. For more documentation on each operator, please refer to
# `this page <https://github.com/pytorch/pytorch/tree/main/torch/_higher_order_ops>`__.

######################################################################
# Constraints/Dynamic Shapes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section will be updated by #3214

angelayi
angelayi commented Jan 6, 2025
View reviewed changes
intermediate_source/torch_export_tutorial.py

######################################################################
# Decompositions
# --------------
# IR/Decompositions
Copy link
Contributor Author

@angelayi angelayi Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tugsbayasgalan -- I updated the tutorial for run_decompositions

@angelayi angelayi changed the base branch from main to 2.6-RC-TEST January 6, 2025 18:32
@angelayi angelayi added 2.6 Tracking 2.6 version PRs. and removed stale Stale PRs labels Jan 6, 2025
svekars
svekars approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We'll merge into main when 2.6 binaries are pulled there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucylq lucylq lucylq approved these changes

@svekars svekars svekars approved these changes

Assignees
No one assigned
Labels
2.6 Tracking 2.6 version PRs. cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@angelayi @svekars @lucylq @facebook-github-bot @HanBnrd @janeyx99 @zou3519