Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example recipes for CPU and XPU #2160

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zxd1997066
Copy link

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

We verified LoRA single device finetuning for below models on both CPU and XPU. Add example recipes for them to show the support of CPU and XPU. Firstly, we added example recipes for Llama3.2 3B LoRA single device finetuning. If it is OK, we can add example recipes for remaining models.

Model Sizes
Llama3.2-Vision 11B
Llama3.2 3B
Llama3.1 8B
Llama3 8B
Llama2 7B
Code-Llama2 7B
Mistral 7B
Gemma 7B
Microsoft Phi3 Mini
Qwen2 1.5B

Changelog

What are the changes made in this PR?

  • Add example recipes for CPU and XPU, and register them in torchtune/_recipe_registry.py

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Dec 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2160

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 16, 2024
@zxd1997066 zxd1997066 changed the title Add example recipes for meta-llama/Llama-3.2-3B-Instruct cpu and xpu Add example recipes for CPU and XPU Dec 16, 2024
@SalmanMohammadi
Copy link
Collaborator

Hey @zxd1997066. Thanks so much for opening this. It looks like the main addition in these configs is updating output_dir and device. I wonder if it might be overkill to to add entire configs just to change the device arg, particularly if it's not as easy to maintain these configs without access to XPU-enabled hardware. What are your thoughts?

In the spirit of this PR, I think we can do more to surface our multi-device support. Perhaps we could add a section to our README or our docs to show how you can use a CLI override to easily change the device (e.g. device=xpu)?

@joecummings
Copy link
Contributor

Hey @zxd1997066. Thanks so much for opening this. It looks like the main addition in these configs is updating output_dir and device. I wonder if it might be overkill to to add entire configs just to change the device arg, particularly if it's not as easy to maintain these configs without access to XPU-enabled hardware. What are your thoughts?

In the spirit of this PR, I think we can do more to surface our multi-device support. Perhaps we could add a section to our README or our docs to show how you can use a CLI override to easily change the device (e.g. device=xpu)?

Seconded! We want to be careful about how many recipes we maintain in our core library. I'd love if you wanted to add a comment to the configs (that you've tested for), similar to how we outline options for our memory optimization techniques. E.g.

device: cuda  # can also use xpu, npu, or cpu

And then we can add a highlight to our documentation, as well. How does this sound?

@zxd1997066
Copy link
Author

Hi @SalmanMohammadi @joecummings , thanks for the suggestions, they sound good, and we will take a look at them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants