Remove streamType field from DecodedOutput
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Jan 21, 2025
| frameFormat, | ||
| expectedOutputWidth, | ||
| expectedOutputHeight}; | ||
| // We need to compare the current frame context with our previous frame |
There was a problem hiding this comment.
Diff looks bigger than it actually is because this block got indented to the left.
scotts
approved these changes
Jan 21, 2025
scotts
reviewed
Jan 21, 2025
| @@ -869,7 +869,6 @@ VideoDecoder::DecodedOutput VideoDecoder::convertAVFrameToDecodedOutput( | |||
| AVFrame* frame = rawOutput.frame.get(); | |||
| output.streamIndex = streamIndex; | |||
| auto& streamInfo = streams_[streamIndex]; | |||
| output.streamType = streams_[streamIndex].stream->codecpar->codec_type; | |||
There was a problem hiding this comment.
I do think there is some value in doing a TORCH_CHECK(streamInfo.stream->codecpar->codec_type == AVMEDIA_TYPE_VIDEO) here or close by to make our assumptions explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pretend to support other types than
AVMEDIA_TYPE_VIDEOwith this field, but this is a lie. We have strong baked-in assumptions everywhere that we currently only support video frames. The main indicator is that we don't allow to add a stream that's not a video stream.Since we'll be tackling audio support soon, I think it's best to remove any relics from the past, since the code-base has evolved in ways that may now be incompatible with how we projected things at the time. Or, said differently, we don't want our design of audio support to be influenced by code we wrote 6 months ago.