Generalize logic to recreate colorspace conversion objects #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes both colorspace conversion options (swscale, filtergraph) resilient to variable resolution frames on the same stream.
For swscale, this was already the case. We were remembering the frame context (decoded resolution, expected resolution, pixel format), and if that ever changed, we recreated the necessary sws objects. This PR generalizes this logic and also does it for filtergraph.
Note that we're also bumping the version number to 0.1.2a0. We neglected to do this after the 0.1.0 and 0.1.1 releases. That is, we did it on the appropriate release branches, but our main repo was still on 0.0.4a0.