Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Add basic gpu test workflow #106

Merged
merged 4 commits into from
Apr 10, 2024
Merged

.github: Add basic gpu test workflow #106

merged 4 commits into from
Apr 10, 2024

Conversation

seemethere
Copy link
Member

Adds a basic test workflow on a CUDA executor to install requirements and run generate.py per @malfet's suggestion.

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@seemethere seemethere marked this pull request as draft April 10, 2024 18:54
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 10, 2024
Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@malfet
Copy link
Contributor

malfet commented Apr 10, 2024

Please update https://github.com/pytorch/torchat/blob/main/.github/workflows/compile_t4.yml (also, not sure why we are installing torchvision and torchaudio here...)

And not sure what nova is using as docker container, but using nightly pytorch docker is probably the right move here

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@mikekgfb mikekgfb self-requested a review April 10, 2024 19:13
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@seemethere seemethere changed the title .github: Add basic test workflow .github: Add basic gpu test workflow Apr 10, 2024
@seemethere seemethere marked this pull request as ready for review April 10, 2024 19:44
@seemethere
Copy link
Member Author

Okay base test job that I added looks good, going to go ahead and merge this and @mikekgfb and team can work on the actual tests

@seemethere seemethere merged commit 479b24b into main Apr 10, 2024
6 checks passed
@seemethere seemethere deleted the seemethere/add_test branch April 15, 2024 22:16
malfet pushed a commit that referenced this pull request Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants