forward 'save_every_n_eval_epochs', 'best_checkpoint_config' to checkpointers #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D52845663 |
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Jan 18, 2024
…pointers (pytorch#680) Summary: Forwards the arguments of best checkpointing to DCP and TSS checkpointers 1. Adds `save_every_n_eval_epochs` arg 2. Augments `keep_last_n_checkpoints` docstring to reference it's compatibility w/ best checkpoint feature 3. Adds `best_checkpoint_config` arg 4. Adds note on how the metric value is retrieved for best checkpoint feature in both checkpointer docstrings Reviewed By: galrotem Differential Revision: D52845663
…pointers (pytorch#680) Summary: Forwards the arguments of best checkpointing to DCP and TSS checkpointers 1. Adds `save_every_n_eval_epochs` arg 2. Augments `keep_last_n_checkpoints` docstring to reference it's compatibility w/ best checkpoint feature 3. Adds `best_checkpoint_config` arg 4. Adds note on how the metric value is retrieved for best checkpoint feature in both checkpointer docstrings Reviewed By: galrotem Differential Revision: D52845663
JKSenthil
force-pushed
the
export-D52845663
branch
from
af7c88e to
07c85f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52845663 |
JKSenthil
force-pushed
the
export-D52845663
branch
from
07c85f3 to
264818d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52845663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Forwards the arguments of best checkpointing to DCP and TSS checkpointers
save_every_n_eval_epochsargkeep_last_n_checkpointsdocstring to reference it's compatibility w/ best checkpoint featurebest_checkpoint_configargDifferential Revision: D52845663