add restore_from_best to BaseCheckpointer
#677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D52746033 |
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Jan 13, 2024
Summary: # Context We are adding best checkpoint feature in TNT checkpointers. This requires us to save, as well as load the best checkpoint. # This Diff Adds `restore_from_best` method to load from best checkpoint # Next Diff Implement save best checkpoint Differential Revision: D52746033
JKSenthil
force-pushed
the
export-D52746033
branch
from
8a7c148 to
2bd9133
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52746033 |
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Jan 16, 2024
Summary: # Context We are adding best checkpoint feature in TNT checkpointers. This requires us to save, as well as load the best checkpoint. # This Diff Adds `restore_from_best` method to load from best checkpoint # Next Diff Implement save best checkpoint Reviewed By: galrotem Differential Revision: D52746033
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Jan 17, 2024
Summary: # Context We are adding best checkpoint feature in TNT checkpointers. This requires us to save, as well as load the best checkpoint. # This Diff Adds `restore_from_best` method to load from best checkpoint # Next Diff Implement save best checkpoint Reviewed By: galrotem Differential Revision: D52746033
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Jan 17, 2024
Summary: # Context We are adding best checkpoint feature in TNT checkpointers. This requires us to save, as well as load the best checkpoint. # This Diff Adds `restore_from_best` method to load from best checkpoint # Next Diff Implement save best checkpoint Reviewed By: galrotem Differential Revision: D52746033
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Jan 17, 2024
Summary: # Context We are adding best checkpoint feature in TNT checkpointers. This requires us to save, as well as load the best checkpoint. # This Diff Adds `restore_from_best` method to load from best checkpoint # Next Diff Implement save best checkpoint Reviewed By: galrotem Differential Revision: D52746033
JKSenthil
force-pushed
the
export-D52746033
branch
from
2bd9133 to
95e2c65
Compare
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Jan 17, 2024
Summary: # Context We are adding best checkpoint feature in TNT checkpointers. This requires us to save, as well as load the best checkpoint. # This Diff Adds `restore_from_best` method to load from best checkpoint # Next Diff Implement save best checkpoint Reviewed By: galrotem Differential Revision: D52746033
|
This pull request was exported from Phabricator. Differential Revision: D52746033 |
Summary: # Context We are adding best checkpoint feature in TNT checkpointers. This requires us to save, as well as load the best checkpoint. # This Diff Adds `restore_from_best` method to load from best checkpoint # Next Diff Implement save best checkpoint Reviewed By: galrotem Differential Revision: D52746033
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Jan 17, 2024
Summary: # Context We are adding best checkpoint feature in TNT checkpointers. This requires us to save, as well as load the best checkpoint. # This Diff Adds `restore_from_best` method to load from best checkpoint # Next Diff Implement save best checkpoint Reviewed By: galrotem Differential Revision: D52746033
JKSenthil
force-pushed
the
export-D52746033
branch
from
95e2c65 to
efc0f97
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52746033 |
JKSenthil
force-pushed
the
export-D52746033
branch
from
efc0f97 to
d8ce0dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52746033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
We are adding best checkpoint feature in TNT checkpointers. This requires us to save, as well as load the best checkpoint.
This Diff
Adds
restore_from_bestmethod to load from best checkpointNext Diff
Implement save best checkpoint
Differential Revision: D52746033