Skip to content

Commit

Permalink
run build_docs on pull request (#664)
Browse files Browse the repository at this point in the history
Summary:


# Context
Pull requests don't run build docs command, so if that breaks it is only seen after commit lands

# This Diff
1. Makes build docs job run on all pull requests
2. creates sub job for publish that only runs on commit (so it won't publish docs for every pull request)

Reviewed By: galrotem

Differential Revision: D52379374
  • Loading branch information
JKSenthil authored and facebook-github-bot committed Dec 27, 2023
1 parent 5226fb3 commit f045f62
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/build_docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: Build and Update Docs
on:
push:
branches: [ master ]
pull_request:

# Allow one concurrent deployment
concurrency:
Expand Down Expand Up @@ -40,6 +41,10 @@ jobs:
make html
touch build/html/.nojekyll
cd ..
publish_docs:
runs-on: ubuntu-latest
if: ${{ github.event_name == 'push' }}
steps:
- name: Deploy docs to Github pages
uses: JamesIves/github-pages-deploy-action@v4.4.1
with:
Expand Down

0 comments on commit f045f62

Please sign in to comment.