Sqlfluff linting existing clickhouse queries pt2 #6311
Draft
+263
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
Camyll
commented
Feb 20, 2025
| workflow.name | ||
| SELECT | ||
| COUNT(*) AS COUNT, | ||
| WORKFLOW.NAME AS NAME |
There was a problem hiding this comment.
@clee2000 is this the correct behavior? I'm not too familiar with clickhouse so I wasn't sure if this syntax is correct
There was a problem hiding this comment.
No, I think all of the capitalizations it changed here should not be done
Camyll
commented
Feb 20, 2025
| from default.workflow_job -- FINAL not needed since we just use this to filter a table that has already been FINALed | ||
| where | ||
| status = 'queued' | ||
| and created_at < (CURRENT_TIMESTAMP() - interval 5 minute) |
There was a problem hiding this comment.
@clee2000 do you know if we also want to have this behavior where if the file starts off with sql commands in lowercase that it makes everything else lowercase?
There was a problem hiding this comment.
IMO it would be better to always stick to either upper case or lower case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint existing clickhouse queries with new sqlfluff linter in a few separated PRs. (part two)