Skip to content

Commit

Permalink
[ez] uploadQueryLambdas - Allow description for lambdas to be differe…
Browse files Browse the repository at this point in the history
…nt types (#5039)

Sometimes the description from the query lambda on rockset is null and
the local description is empty, and the script attempts to update the
lambda. This made me hit rate limits when trying to update from local.
I assume this is just a typing thing and that this is just two different
ways of saying that there is no description, so add a check for that.
  • Loading branch information
clee2000 authored Mar 22, 2024
1 parent 580a677 commit 694ea2c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion torchci/scripts/uploadQueryLambda.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ async function upload(workspace, queryName, queryLambdas) {
}

if (
queryLambda.description == config.description &&
(queryLambda.description == config.description ||
(queryLambda.description == null && config.description == "")) &&
equalParametersList(
queryLambda.default_parameters,
config.default_parameters
Expand Down

0 comments on commit 694ea2c

Please sign in to comment.