[Feature] Ensure transformation keys have the same number of elements

[antoinebrl]

Description

From the documentation and tests it is implicit that the number of in and out keys should match in the transformations. I'm proposing to enforce that through a runtime check by adding the strict=True when using zip. If the sequences don't have the same number of elements a ValueError is raised.

Let me know if you think enforcing this assumption requires some tests. Happy to take your suggestions if you have an idea on how to easily test all the calls to zip.

Motivation and Context

This will ensure the keys are provided by pairs. Currently last elements of the longest list are ignored.

Types of changes

Not sure if preventing silent errors should be considered a bug fix or a new feature to guide the users.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds core functionality)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

• I have read the CONTRIBUTION guide (required)
• My change requires a change to the documentation.
• I have updated the tests accordingly (required for a bug fix or a new feature).
• I have updated the documentation accordingly.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2466

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 23 New Failures, 1 Cancelled Job, 6 Unrelated Failures

As of commit 2ea42b7 with merge base b116151 ():

NEW FAILURES - The following jobs have failed:

• Continuous Benchmark (PR) / CPU Pytest benchmark (gh)
  E ImportError: cannot import name 'interaction_mode' from 'tensordict.nn.probabilistic' (/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/tensordict/nn/probabilistic.py)
• Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
  E ImportError: cannot import name 'interaction_mode' from 'tensordict.nn.probabilistic' (/__w/_tool/Python/3.9.20/x64/lib/python3.9/site-packages/tensordict/nn/probabilistic.py)
• Continuous Benchmark / CPU Pytest benchmark (gh)
  E ImportError: cannot import name 'interaction_mode' from 'tensordict.nn.probabilistic' (/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/tensordict/nn/probabilistic.py)
• Continuous Benchmark / GPU Pytest benchmark (gh)
  E ImportError: cannot import name 'interaction_mode' from 'tensordict.nn.probabilistic' (/__w/_tool/Python/3.9.20/x64/lib/python3.9/site-packages/tensordict/nn/probabilistic.py)
• Examples Tests on Linux / tests (3.9, 12.1) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Generate documentation / build-docs (3.9, 12.1) / linux-job (gh)
  ##[error]No files were found with the provided path: /home/ec2-user/actions-runner/_work/_temp/artifacts/. No artifacts will be uploaded.
• Habitat Tests on Linux / tests (3.9, 12.1) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Libs Tests on Linux / unittests-gym (3.9, 12.1) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Libs Tests on Linux / unittests-sklearn (3.9, 12.1) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Lint / c-source / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Lint / python-source-and-configs / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• RLHF Tests on Linux / unittests (3.9, 12.1) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Linux / tests-cpu (3.10) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Linux / tests-cpu (3.11) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Linux / tests-cpu (3.12) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Linux / tests-cpu (3.9) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Linux / tests-cpu-oldget (3.12) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Linux / tests-gpu (3.11, 12.1) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Linux / tests-optdeps (3.10, 12.1) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Unit-tests on Windows / unittests-cpu / windows-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/2466/merge
• Wheels / test-wheel-windows (3.9) (gh)
  ImportError: cannot import name 'interaction_mode' from 'tensordict.nn.probabilistic' (C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\site-packages\tensordict\nn\probabilistic.py)

CANCELLED JOB - The following job was cancelled. Please retry:

• Wheels / test-wheel-windows (3.11) (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• Wheels / test-wheel-windows (3.10) (gh) (matched win rule in flaky-rules.json)
  ##[error]The operation was canceled.
• Wheels / test-wheel-windows (3.12) (gh) (matched win rule in flaky-rules.json)
  ##[error]The operation was canceled.

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cpu (gh) (trunk failure)
  ##[error]Unable to find any artifacts for the associated workflow
• Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cuda11_8 (gh) (trunk failure)
  ##[error]Unable to find any artifacts for the associated workflow
• Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cuda12_1 (gh) (trunk failure)
  ##[error]Unable to find any artifacts for the associated workflow
• Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cuda12_4 (gh) (trunk failure)
  ##[error]Unable to find any artifacts for the associated workflow

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[vmoens]

It's a great feature! Just need to make it work with earlier versions of python

[vmoens]

LGTM thanks!