[Feature] Check number of kwargs matches num_workers

[antoinebrl]

Description

Add runtime checks to ensure the create_env_kwargs and kwargs passed to the __init__() and update_kwargs() respectively have the right number of elements, i.e. the number of workers.

Motivation and Context

An off by one error got me pretty hard.

Types of changes

Not sure if that is a bug fix or a new feature to add these checks.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds core functionality)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

• I have read the CONTRIBUTION guide (required)
• My change requires a change to the documentation.
• I have updated the tests accordingly (required for a bug fix or a new feature).
• I have updated the documentation accordingly.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2465

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 6 Unrelated Failures

As of commit 684e15a with merge base 4790d3b ():

NEW FAILURES - The following jobs have failed:

• Continuous Benchmark (PR) / CPU Pytest benchmark (gh)
  ../../../../../../tmp/test_collectors_benchmark.py::TestRBGCollector::test_multiasync_rb[16-2]
• Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
  Fatal Python error: Fatal Python error: Fatal Python error: Fatal Python error: Bus errorBus error
• Continuous Benchmark / CPU Pytest benchmark (gh)
  ##[error]Process completed with exit code 135.
• Continuous Benchmark / GPU Pytest benchmark (gh)
  Bus error
• Habitat Tests on Linux / tests (3.9, 12.1) / linux-job (gh)
  RuntimeError: Command docker exec -t 3de925e8f660fbcb805b1d4cce61a7aff341286ce0a56aa24e8802282d53bc3c /exec failed with exit code 134

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cpu (gh) (trunk failure)
  ##[error]Unable to find any artifacts for the associated workflow
• Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cuda11_8 (gh) (trunk failure)
  ##[error]Unable to find any artifacts for the associated workflow
• Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cuda12_1 (gh) (trunk failure)
  ##[error]Unable to find any artifacts for the associated workflow
• Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cuda12_4 (gh) (trunk failure)
  ##[error]Unable to find any artifacts for the associated workflow
• Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job (gh) (trunk failure)
  test/test_tensordictmodules.py::TestGRUModule::test_gru_vmap_complex_model
• Unit-tests on Windows / unittests-cpu / windows-job (gh) (trunk failure)
  RuntimeError: Compiler: cl is not found.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[vmoens]

LGTM thanks!