[BUG]flatten_tensordicts default to False

[HGGshiwo]

Describe the bug

flatten_tensordicts default to False, while it is said should be True in the annotation.

To Reproduce

Steps to reproduce the behavior.

Please try to provide a minimal example to reproduce the bug. Error messages and stack traces are also helpful.

Please use the markdown code blocks for both code and stack traces.

import torchrl

Traceback (most recent call last):
  File ... 

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

System info

Describe the characteristic of your environment:

• Describe how the library was installed (pip, source, ...)
• Python version
• Versions of any other relevant libraries

import torchrl, numpy, sys
print(torchrl.__version__, numpy.__version__, sys.version, sys.platform)

Additional context

Add any other context about the problem here.

Reason and Possible fixes

If you know or suspect the reason for this bug, paste the code lines and suggest modifications.

Checklist

• I have checked that there is no similar issue in the repo (required)
• I have read the documentation (required)
• I have provided a minimal working example to reproduce the bug (required)

[vmoens]

Hey can you provide a bit more details about this issue? What annotation are we talking about? Do you mean docstrings? Of which function?
Thanks!

[HGGshiwo]

Hey can you provide a bit more details about this issue? What annotation are we talking about? Do you mean docstrings? Of which function? Thanks!

It is an arg in Trainer.__init__, the link is https://github.com/pytorch/rl/blob/main/torchrl/trainers/trainers.py#L639, you can see it is False in default, but True in comments

[vmoens]

Ah ok, trainer was not mentioned!