Support bare-metal Windows #3735
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3735
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@cccclai - can you take a look please? |
|
This is great! Thank you for adding this and sorry I've been missing this pull request. It's definately something we'd like to add. It may take some time to review though as it involves changes in both the the qualcomm backend and core runtime |
| @@ -185,6 +247,34 @@ Result<FreeableBuffer> FileDataLoader::Load(size_t offset, size_t size) { | |||
| // Read the data into the aligned address. | |||
| size_t needed = size; | |||
| uint8_t* buf = reinterpret_cast<uint8_t*>(aligned_buffer); | |||
| #ifdef _WIN32 | |||
There was a problem hiding this comment.
cc @dbort on the data loader changes
runtime/backend/interface.cpp
Outdated
| #ifdef _WIN32 | ||
|
|
||
| #define SHARED_MEMORY_NAME "torch_executor_backend_registry" | ||
| static std::shared_ptr<torch::executor::BackendRegistry> backend_reg; |
There was a problem hiding this comment.
cc @cccclai on the backend changes. Personally seeing shared_ptr in the core runtime is scary to me even if its gated behind windows which afaik should always have malloc and atomic available
There was a problem hiding this comment.
Thank you so much for this PR @hans00, and sorry about the delay!
Before we review this, please help us out by splitting this into three independent PRs:
- Changes to
runtime/...files - Changes to
extension/data_loader/...files - Changes to the
qualcommbackend and relatedexamples/changes
If you'd like to stack these PRs on top of each other, we recommend https://github.com/ezyang/ghstack
|
Sorry so late to continue on this PR. P.S. I saw the others trying support Windows (#4661), did there still need help? |
|
There are some PRs merged and some are not yet. Maybe can check out the part that is finished from the description and coordinate together. |
As title.