Fix xnnpack pybind #2802
Closed
Fix xnnpack pybind #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2802
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 25e55f2 with merge base 15d9ddd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mcr229
force-pushed
the
fix_xnnpack_pybind
branch
from
83e5e23 to
bd4e4ef
Compare
kirklandsign
approved these changes
Apr 1, 2024
metascroy
reviewed
Apr 1, 2024
metascroy
approved these changes
Apr 2, 2024
larryliu0820
approved these changes
Apr 2, 2024
|
@mcr229 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: As titled. Add executorch/backends/xnnpack/test/models directory into pytest.ini Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
@mcr229 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing XNNPACK Pybind.
Currently pybindings for xnnpack fail due to uninitialized error. We notice the following:
That is xnn_initialize symbole comes from libtorch_cpu, but when we call xnn_create_subgraph we call it from another library. It seems like explicitly adding XNNPACK to the portable_libs pybind fixes this problem.
Additionaly, we fix some fPIC issues when building XNNPACK.