Skip to content

Arm backend: Fix sigmoid int16 and int32 flakyness #10548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Arm backend: Fix sigmoid int16 and int32 flakyness #10548

wants to merge 2 commits into from

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Apr 29, 2025 •
edited by pytorch-bot bot
Loading

Step vela pin and remove all related pytest.mark_flaky in sigmoid int16 and int32 tests.

cc @digantdesai @freddan80 @per @zingo

@oscarandersson8218
Arm backend: Fix sigmoid int16 and int32 flakyness
5ba59c2 
MLBEDSW-10642 has now been resolved. Step vela pin and remove all
related pytest.mark_flaky in sigmoid int16 and int32 tests.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I8c1aff31fb173fa6fdebc1d5b757623f9c2e1321
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10548

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 2120c63 with merge base 6371758 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 29, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Apr 29, 2025
@zingo
Copy link
Collaborator

zingo commented Apr 29, 2025 •
edited
Loading

@digantdesai this is also steping Vela (e.g. it's newer then #9893 ) Maybe you want to merge both PRs at the same time using the version of Vela from this PR.

EDIT we need to update this PR a bit more @digantdesai do not merge it yet

@oscarandersson8218
Copy link
Collaborator Author

Need to investigate some of the failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oscarandersson8218 @zingo @facebook-github-bot