Skip to content

Commit

Permalink
Disable wheel delocation on macos
Browse files Browse the repository at this point in the history
The executorch build system will ensure that .dylib/.so files have
LC_LOAD_DYLIB and LC_RPATH entries that will work when they're
installed.

Delocating (i.e., making copies of the .dylibs that ET's libs depend on)
will break any libs that depend on the torch libraries if users ever
import both `torch` and the executorch library. Both import paths must
load exactly the same file, not just a copy of it.
  • Loading branch information
dbort committed Apr 22, 2024
1 parent 8c4eb48 commit aa51190
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build-wheels-m1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
# "recursive" default to do less work, and to give the buck daemon fewer
# files to look at.
submodules: true
delocate-wheel: false
env-var-script: build/packaging/env_var_script_m1.sh
pre-script: ${{ matrix.pre-script }}
post-script: ${{ matrix.post-script }}
Expand Down

0 comments on commit aa51190

Please sign in to comment.