Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address remaining mypy errors - mypy checks passing now #1235

Closed
wants to merge 1 commit into from
Closed

Address remaining mypy errors - mypy checks passing now #1235

wants to merge 1 commit into from

Conversation

gokulavasan
Copy link
Contributor

@gokulavasan gokulavasan commented Mar 26, 2024 •
edited
Loading

Address remaining mypy errors (8 that were left)

Changes

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 26, 2024
@gokulavasan
Fix remaining mypy issues mostly ignoring them
9dda532 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@gokulavasan gokulavasan changed the title Attempt fixes to init pyi Address remaining mypy errors - mypy checks passing now Mar 26, 2024
@gokulavasan gokulavasan requested a review from andrewkho March 26, 2024 08:00
@gokulavasan gokulavasan marked this pull request as ready for review March 26, 2024 08:00
@gokulavasan gokulavasan requested a review from ejguan March 26, 2024 08:01
@facebook-github-bot
Copy link
Contributor

@gokulavasan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gokulavasan merged this pull request in 88a1d34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejguan ejguan ejguan approved these changes

@andrewkho andrewkho Awaiting requested review from andrewkho

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gokulavasan @facebook-github-bot @ejguan