-
Notifications
You must be signed in to change notification settings - Fork 161
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Address remaining mypy errors - mypy checks passing now (#1235)
Summary: Address remaining mypy errors (8 that were left) ### Changes - Had to import Literal and two string literals in __init__.py.in which were used in https://github.com/pytorch/pytorch/blob/d1f58eaaf500da8040e65780b7db171dff953e8a/torch/utils/data/datapipes/iter/combining.py#L147. This addressed 3 out of the 8 remaining errors - For rest 5, I chose to add type ignore statements to skip mypy checks as they are not being actively developed Pull Request resolved: #1235 Reviewed By: ejguan Differential Revision: D55374270 Pulled By: gokulavasan fbshipit-source-id: ce130c3f35e5218eddabf16a4dfee283ac0ae142
- Loading branch information
1 parent
2b831b3
commit 88a1d34
Showing
4 changed files
with
7 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters