Remove voucher columns from Grant model #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4335 +/- ##
==========================================
- Coverage 94.45% 94.45% -0.01%
==========================================
Files 349 349
Lines 9950 9948 -2
Branches 700 700
==========================================
- Hits 9398 9396 -2
Misses 462 462
Partials 90 90 |
| @@ -461,9 +459,6 @@ class GrantAdmin(ExportMixin, ConferencePermissionMixin, admin.ModelAdmin): | |||
| "total_amount", | |||
| "applicant_reply_sent_at", | |||
| "applicant_reply_deadline", | |||
| "pretix_voucher_id", | |||
There was a problem hiding this comment.
It might be beneficial to expose in this admin something that checks if a ConferenceVoucher exists for this grant user, so we don't need to go to a different UI to check if this grant has the voucher or not. What do you think?
There was a problem hiding this comment.
I added the columns has_voucher and has_ticket
Removed the columns `pretix_voucher_id`, `voucher_code`, and `voucher_email_sent_at` from the `Grant` model. These columns are no longer needed as we now use the `ConferenceVoucher` table for voucher management.
estyxx
force-pushed
the
grants/remove-voucher-columns
branch
from
200c32e to
ff5d55f
Compare
marcoacierno
reviewed
Feb 8, 2025
marcoacierno
reviewed
Feb 8, 2025
Added `has_ticket` and `has_voucher` columns to the GrantAdmin model to determine if a user has a voucher or has redeemed a ticket. The `has_ticket` data is fetched from Pretix via the API, while the `has_voucher` data is retrieved from the `ConferenceVoucher` table.
estyxx
force-pushed
the
grants/remove-voucher-columns
branch
from
ff5d55f to
d45033f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the columns
pretix_voucher_id,voucher_code, andvoucher_email_sent_atfrom theGrantmodel. These columns are nolonger needed as we now use the
ConferenceVouchertable for vouchermanagement.
What
ToDo