-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confirmation email for grant application #4177
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4177 +/- ##
==========================================
- Coverage 94.08% 94.07% -0.02%
==========================================
Files 331 331
Lines 9156 9157 +1
Branches 1347 1347
==========================================
Hits 8614 8614
- Misses 452 453 +1
Partials 90 90 |
@@ -29,6 +29,10 @@ class EmailTemplateIdentifier(models.TextChoices): | |||
|
|||
reset_password = "reset_password", _("[System] Reset password") | |||
|
|||
grant_application_confirmation = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this name is clear enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any better ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't think of a better name, "application" is what threw me off a bit but it is not a big deal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you merge this and it is deployed, can you create the template in admin?
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
What
Sends a confirmation email to the applicant acknowledging receipt of their grant application.
ToDo