Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation email for grant application #4177

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

estyxx
Copy link
Member

@estyxx estyxx commented Nov 24, 2024

What

Sends a confirmation email to the applicant acknowledging receipt of their grant application.

ToDo

Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
pycon ✅ Ready (Inspect) Visit Preview Nov 30, 2024 2:54pm

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.07%. Comparing base (90be065) to head (f162951).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
- Coverage   94.08%   94.07%   -0.02%     
==========================================
  Files         331      331              
  Lines        9156     9157       +1     
  Branches     1347     1347              
==========================================
  Hits         8614     8614              
- Misses        452      453       +1     
  Partials       90       90              

@estyxx estyxx marked this pull request as ready for review November 30, 2024 14:51
@@ -29,6 +29,10 @@ class EmailTemplateIdentifier(models.TextChoices):

reset_password = "reset_password", _("[System] Reset password")

grant_application_confirmation = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this name is clear enough?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any better ideas?

Copy link
Member

@marcoacierno marcoacierno Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't think of a better name, "application" is what threw me off a bit but it is not a big deal

Copy link
Member

@marcoacierno marcoacierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you merge this and it is deployed, can you create the template in admin?

@estyxx estyxx merged commit 86af124 into main Dec 1, 2024
7 checks passed
@estyxx estyxx deleted the grants/application-confirmation-email branch December 1, 2024 10:40
@marcoacierno marcoacierno linked an issue Dec 1, 2024 that may be closed by this pull request
Copy link

sentry-io bot commented Dec 1, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Grant.DoesNotExist: Grant matching query does not exist. grants.tasks.send_grant_application_confirmatio... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send confirmation emails
2 participants