Grants email voucher copy update #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
estyxx
commented
Feb 9, 2024
•
estyxx
commented
- Remove visa_application_form_link
- Update voucher copy email
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3717 +/- ##
==========================================
- Coverage 90.46% 90.46% -0.01%
==========================================
Files 268 268
Lines 7250 7246 -4
Branches 1087 1086 -1
==========================================
- Hits 6559 6555 -4
Misses 623 623
Partials 68 68 |
estyxx
commented
Feb 13, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| </p> | ||
| <div class="leading-full items-center justify-center flex mb-4" | ||
| style="justify-content: center"> | ||
| <a href="@{{ replyLink }}" |
Check warning
Code scanning / CodeQL
Potentially unsafe external link Medium
estyxx
force-pushed
the
feature/grants-email-voucher-copy-update
branch
from
ed8fa03 to
b864017
Compare
estyxx
commented
Feb 13, 2024
| to make sure it works with Wagtail's ALLOWED_HOSTS in test environments. | ||
| """ | ||
|
|
||
| hostname = "testserver" |
There was a problem hiding this comment.
I would leave this anyway as this fixture is more specifc aka links the GenericPage as root_pag and use testserver as hostname that is the allowed hosts configured by wagtail in the tests I discovered.
marcoacierno
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.