Grants: email copy updates #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3712 +/- ##
==========================================
+ Coverage 90.41% 90.46% +0.05%
==========================================
Files 268 268
Lines 7253 7250 -3
Branches 1090 1087 -3
==========================================
+ Hits 6558 6559 +1
+ Misses 625 623 -2
+ Partials 70 68 -2 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| </p> | ||
| <div class="leading-full items-center justify-center flex mb-4" | ||
| style="justify-content: center"> | ||
| <a href="@{{ replyLink }}" |
Check warning
Code scanning / CodeQL
Potentially unsafe external link Medium
marcoacierno
reviewed
Feb 7, 2024
| ) | ||
| and grant.accommodation_amount is None | ||
| ): | ||
| if grant.has_approved_accommodation() and grant.accommodation_amount is None: |
There was a problem hiding this comment.
not for this PR, but we have a very similar logic in the Grant save method when it calculates the amounts to set. We could refactor it to use those 2 new methods
marcoacierno
reviewed
Feb 7, 2024
Co-authored-by: Marco Acierno <marcoaciernoemail@gmail.com>
…talia/pycon into feature/update-grants-email-copy
marcoacierno
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How to test it