Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposals Review improvements #3696

Merged
merged 6 commits into from
Jan 28, 2024
Merged

Proposals Review improvements #3696

merged 6 commits into from
Jan 28, 2024

Conversation

marcoacierno
Copy link
Member

Why

How to test it

Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
pycon ✅ Ready (Inspect) Visit Preview Jan 28, 2024 1:31am

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Merging #3696 (4222465) into main (b2b63f1) will decrease coverage by 0.05%.
The diff coverage is 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3696      +/-   ##
==========================================
- Coverage   90.25%   90.21%   -0.05%     
==========================================
  Files         267      268       +1     
  Lines        7203     7212       +9     
  Branches     1082     1083       +1     
==========================================
+ Hits         6501     6506       +5     
- Misses        631      634       +3     
- Partials       71       72       +1     

{% if grant %}
<div>
<a target="_blank" href="{{grant_link}}">Yes, open grant</a>
<a target="_blank" href="{{grant_link}}">Yes, open grant in admin</a>

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
@marcoacierno marcoacierno merged commit 1be1068 into main Jan 28, 2024
7 of 9 checks passed
@marcoacierno marcoacierno deleted the reviews-fixes branch January 28, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant