Store privacy policy in newsletter

backend/api/newsletters/mutations/subscribe_to_newsletter.py

@@ -1,6 +1,8 @@
 from api.utils import get_ip
 import requests
 import logging
+from privacy_policy.record import record_privacy_policy_acceptance
+from conferences.models.conference import Conference
 from integrations.flodesk import SubscriptionResult, subscribe
 from typing import Annotated, Union
 from api.context import Info
@@ -28,6 +30,7 @@ class SubscribeToNewsletterErrors(BaseErrorType):
     @strawberry.type
     class _SubscribeToNewsletterErrors:
         email: list[str] = strawberry.field(default_factory=list)
+        conference_code: list[str] = strawberry.field(default_factory=list)
         non_field_errors: list[str] = strawberry.field(default_factory=list)
 
     errors: _SubscribeToNewsletterErrors = None
@@ -36,6 +39,7 @@ class _SubscribeToNewsletterErrors:
 @strawberry.input
 class SubscribeToNewsletterInput:
     email: str
+    conference_code: str
 
     def validate(self) -> SubscribeToNewsletterErrors:
         errors = SubscribeToNewsletterErrors()
@@ -48,6 +52,9 @@ def validate(self) -> SubscribeToNewsletterErrors:
             except ValidationError:
                 errors.add_error("email", "Invalid email address")
 
+        if not Conference.objects.filter(code=self.conference_code).exists():
+            errors.add_error("conference_code", "Invalid conference code")
+
         return errors.if_has_errors
 
 
@@ -64,11 +71,14 @@ def subscribe_to_newsletter(
     if errors := input.validate():
         return errors
 
+    conference = Conference.objects.get(code=input.conference_code)
     email = input.email
     request = info.context.request
 
     try:
-        return NewsletterSubscribeResult(status=subscribe(email, ip=get_ip(request)))
+        result = NewsletterSubscribeResult(status=subscribe(email, ip=get_ip(request)))
+        record_privacy_policy_acceptance(info.context.request, conference, "newsletter")
+        return result
     except requests.exceptions.HTTPError as e:
         logger.error(
             "Unable to subscribe the user due to flodesk API error %s %s",

backend/api/tests/schema/test_newsletter.py

@@ -1,5 +1,6 @@
 from unittest.mock import patch
 
+from conferences.tests.factories import ConferenceFactory
 from users.tests.factories import UserFactory
 import pytest
 from pytest import mark
@@ -10,14 +11,13 @@
 
 
 def test_subscribe_to_newsletter(graphql_client):
+    conference = ConferenceFactory()
     email = "me@example.it"
-    variables = {"email": email}
+    variables = {"email": email, "conferenceCode": conference.code}
 
     query = """
-        mutation($email: String!) {
-            subscribeToNewsletter(input: {
-                email: $email
-            }) {
+        mutation($input: SubscribeToNewsletterInput!) {
+            subscribeToNewsletter(input: $input) {
             __typename
 
             ... on NewsletterSubscribeResult {
@@ -32,7 +32,7 @@ def test_subscribe_to_newsletter(graphql_client):
     ) as mock_subscription:
         mock_subscription.return_value = SubscriptionResult.SUBSCRIBED
 
-        resp = graphql_client.query(query, variables=variables)
+        resp = graphql_client.query(query, variables={"input": {variables}})
 
         assert (
             resp["data"]["subscribeToNewsletter"]["__typename"]
@@ -49,14 +49,13 @@ def test_subscribe_to_newsletter(graphql_client):
     ],
 )
 def test_subscribe_to_newsletter_fails_on_api_side(graphql_client, exception):
+    conference = ConferenceFactory()
     email = "me@example.it"
-    variables = {"email": email}
+    variables = {"email": email, "conferenceCode": conference.code}
 
     query = """
-        mutation($email: String!) {
-            subscribeToNewsletter(input: {
-                email: $email
-            }) {
+        mutation($input: SubscribeToNewsletterInput!) {
+            subscribeToNewsletter(input: $input) {
             __typename
 
             ... on NewsletterSubscribeResult {
@@ -71,7 +70,7 @@ def test_subscribe_to_newsletter_fails_on_api_side(graphql_client, exception):
     ) as mock_subscription:
         mock_subscription.side_effect = exception
 
-        resp = graphql_client.query(query, variables=variables)
+        resp = graphql_client.query(query, variables={"input": variables})
 
         assert (
             resp["data"]["subscribeToNewsletter"]["__typename"]
@@ -82,13 +81,12 @@ def test_subscribe_to_newsletter_fails_on_api_side(graphql_client, exception):
 
 @pytest.mark.parametrize("email", ["", "me-invalid"])
 def test_subscribe_to_newsletter_with_invalid_email_fails(graphql_client, email):
-    variables = {"email": email}
+    conference = ConferenceFactory()
+    variables = {"email": email, "conferenceCode": conference.code}
 
     query = """
-        mutation($email: String!) {
-            subscribeToNewsletter(input: {
-                email: $email
-            }) {
+        mutation($input: SubscribeToNewsletterInput!) {
+            subscribeToNewsletter(input: $input) {
             __typename
 
             ... on SubscribeToNewsletterErrors {
@@ -105,7 +103,7 @@ def test_subscribe_to_newsletter_with_invalid_email_fails(graphql_client, email)
     ) as mock_subscription:
         mock_subscription.return_value = SubscriptionResult.SUBSCRIBED
 
-        resp = graphql_client.query(query, variables=variables)
+        resp = graphql_client.query(query, variables={"input": variables})
 
         assert (
             resp["data"]["subscribeToNewsletter"]["__typename"]
@@ -116,9 +114,46 @@ def test_subscribe_to_newsletter_with_invalid_email_fails(graphql_client, email)
         ]
 
 
+@pytest.mark.parametrize("conference_code", ["", "invalid-conf"])
+def test_subscribe_to_newsletter_with_invalid_conference_code(
+    graphql_client, conference_code
+):
+    ConferenceFactory(code="valid")
+    variables = {"email": "example@example.com", "conferenceCode": conference_code}
+
+    query = """
+        mutation($input: SubscribeToNewsletterInput!) {
+            subscribeToNewsletter(input: $input) {
+            __typename
+
+            ... on SubscribeToNewsletterErrors {
+                errors {
+                    email
+                    conferenceCode
+                }
+            }
+        }
+    }
+    """
+
+    with patch(
+        "api.newsletters.mutations.subscribe_to_newsletter.subscribe"
+    ) as mock_subscription:
+        mock_subscription.return_value = SubscriptionResult.SUBSCRIBED
+        resp = graphql_client.query(query, variables={"input": variables})
+
+    assert (
+        resp["data"]["subscribeToNewsletter"]["__typename"]
+        == "SubscribeToNewsletterErrors"
+    )
+    assert resp["data"]["subscribeToNewsletter"]["errors"]["conferenceCode"] == [
+        "Invalid conference code"
+    ]
+
+
 def _update_user_newsletter(graphql_client, user, open_to_newsletter):
     query = """
-     mutation(
+    mutation(
         $open_to_newsletter: Boolean!,
         $open_to_recruiting: Boolean!,
         $date_birth: String