Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing design of Scenario and single_run #17

Open
TomMonks opened this issue May 22, 2024 · 0 comments
Open

Confusing design of Scenario and single_run #17

TomMonks opened this issue May 22, 2024 · 0 comments
Labels
invalid This doesn't seem right

Comments

@TomMonks
Copy link
Member

The Scenario class allows a user to set a random_number_set. This is also settable with single_run. In effect single_run overwrites Scenario. The result can be confusing. for example

random number set is set via Scenario, but the model is run in single_run mode without setting a seed. This means that the model runs with a random seed as single_run used None.

The design needs to be modified to set the seed in one place.

@TomMonks TomMonks added the invalid This doesn't seem right label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant