Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 772: Packaging governance process #4218

Merged
merged 19 commits into from
Feb 6, 2025

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Jan 21, 2025

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--4218.org.readthedocs.build/pep-0772/

@pradyunsg pradyunsg force-pushed the packaging-governance branch from 95b03c5 to c31e924 Compare January 21, 2025 21:50
@pradyunsg pradyunsg marked this pull request as ready for review January 21, 2025 21:50
@pradyunsg pradyunsg requested a review from a team as a code owner January 21, 2025 21:51
@pradyunsg pradyunsg requested a review from warsaw January 21, 2025 21:51
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
@warsaw
Copy link
Member

warsaw commented Jan 23, 2025

I thought we would put this in PEP 8800 (or other 8X00 range) to rhyme with the Steering Council PEPs in the 8100s?

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, nice work on this PEP. I'm happy to see it moving forward. I've made some comments based on my governance experience. YMMV.

peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
@hugovk
Copy link
Member

hugovk commented Jan 23, 2025

I thought we would put this in PEP 8800 (or other 8X00 range) to rhyme with the Steering Council PEPs in the 8100s?

Hmm, no objection, although this is replacing 609, and the other recent council/WG/board PEPs didn't go in 8xxx:

  PEP Title Authors
PA 609 Python Packaging Authority (PyPA) Governance Dustin Ingram, Pradyun Gedam, Sumana Harihareswara
PA 729 Typing governance process Jelle Zijlstra, Shantanu Jain
PA 731 C API Working Group Charter Guido van Rossum, Petr Viktorin, Victor Stinner, Steve Dower, Irit Katriel
PA 732 The Python Documentation Editorial Board Joanna Jablonski

https://peps.python.org/topic/governance/

peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Outdated Show resolved Hide resolved
@pradyunsg
Copy link
Member Author

Thanks everyone for the reviews here!

Given that there's over a hundred comments on this PR already... I have a couple of "housekeeping"-style requests:

  • I'd appreciate if we avoid extended discussion outside of inline review comments.
    • Replies outside of inline "review comments" are much easier to lose track of when the discussion gets really long with reviews from multiple individuals (which is what is going on here, right now).
    • I'm marking things as resolved to close out relevant subtopics in our discussions here.
  • If I've marked one of your comments as resolved and haven't actually addressed it (and it wasn't a nit pick), please feel welcome mark it as unresolved and add a reply there!

There's still more stuff to be addressed from these reviews... I'll come around to those in my next burst of addressing review comments here (it's late today).

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my suggestions have been addressed. Thanks for working on this!

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with where things stand right now. Thanks @warsaw and @pradyunsg for moving this forward.

Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willingc ; I'm going to get the last few things resolved and get this PEP published.

peps/pep-0772.rst Outdated Show resolved Hide resolved
peps/pep-0772.rst Show resolved Hide resolved
@warsaw warsaw merged commit e95aa67 into python:main Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants