Skip to content

fix: Add explicit extension generic parameter to User class #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vpatov
Copy link

@vpatov vpatov commented May 9, 2025

Fixes #91

»  python -m pytest 
========================================================================== test session starts ==========================================================================
platform linux -- Python 3.10.12, pytest-8.3.5, pluggy-1.5.0
rootdir: /home/vpatov/coreweave/scim2-models
configfile: pyproject.toml
plugins: anyio-4.4.0
collected 96 items                                                                                                                                                      

doc/tutorial.rst .                                                                                                                                                [  1%]
tests/test_dynamic_resources.py .......                                                                                                                           [  8%]
tests/test_dynamic_schemas.py .......                                                                                                                             [ 15%]
tests/test_enterprise_user.py .                                                                                                                                   [ 16%]
tests/test_errors.py .                                                                                                                                            [ 17%]
tests/test_group.py .                                                                                                                                             [ 18%]
tests/test_list_response.py ............                                                                                                                          [ 31%]
tests/test_model_attributes.py .......                                                                                                                            [ 38%]
tests/test_model_serialization.py ...........                                                                                                                     [ 50%]
tests/test_model_validation.py ................                                                                                                                   [ 66%]
tests/test_models.py ....                                                                                                                                         [ 70%]
tests/test_patch_op.py .                                                                                                                                          [ 71%]
tests/test_resource_extension.py ..........                                                                                                                       [ 82%]
tests/test_resource_type.py ....                                                                                                                                  [ 86%]
tests/test_schema.py ....                                                                                                                                         [ 90%]
tests/test_search_request.py .....                                                                                                                                [ 95%]
tests/test_service_provider_configuration.py .                                                                                                                    [ 96%]
tests/test_user.py ..                                                                                                                                             [ 98%]
tests/test_utils.py .                                                                                                                                             [100%]

========================================================================== 96 passed in 2.56s ===========================================================================

@azmeuk
Copy link
Contributor

azmeuk commented May 9, 2025

Please fix the style issue, and then we are ready to merge.

@azmeuk azmeuk added the bug Something isn't working label May 9, 2025
@vpatov vpatov force-pushed the 91-user-generic-params branch from 44cebab to 6bed728 Compare May 9, 2025 14:15
@vpatov
Copy link
Author

vpatov commented May 9, 2025

Fixed the style issue, and ran the pre-commits locally successfully. Not sure how to re-run the style job though to verify it's passing

@vpatov vpatov force-pushed the 91-user-generic-params branch from 6bed728 to 9aaa3d1 Compare May 9, 2025 16:02
@vpatov
Copy link
Author

vpatov commented May 9, 2025

Ah, running the precommit on all files shows the issue. Should be good now

@vpatov
Copy link
Author

vpatov commented May 16, 2025

@azmeuk anything else for this before we can merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scim2_models.User should explicitly declare generic parameter
2 participants