fix(tests): ensure only mocked system site is used #9941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
force-pushed
the
fix-system-site-test
branch
from
1b426c8 to
9c212d4
Compare
radoering
approved these changes
Jan 5, 2025
radoering
previously requested changes
Jan 5, 2025
abn
force-pushed
the
fix-system-site-test
branch
from
9c212d4 to
095a97d
Compare
|
I wrongly assumed the fix was no longer needed based on the previous failure. It seems that with the change the sqlite3 package correctly goes to the system site. I am guessing this should fix it, but lets see if the most recent change fixes it. |
abn
force-pushed
the
fix-system-site-test
branch
from
095a97d to
625df0d
Compare
Previously, on systems where there existed multiple system-site locations the `test_system_site_packages` test case failed due to it incorrectly assuming only one site needed removal when patching the environment's `sys_path`. This change ensures all paths outside the `tmp_path` is ignored.
radoering
force-pushed
the
fix-system-site-test
branch
from
625df0d to
04fce82
Compare
radoering
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on systems where there existed multiple system-site locations the
test_system_site_packagestest case failed due to it incorrectly assuming only one site needed removal when patching the environment'ssys_path. This change ensures all paths outside thetmp_pathis ignored.