Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: disable keyring instead of setting a fail keyring #304

Merged
merged 1 commit into from
Nov 17, 2024
Merged

tests: disable keyring instead of setting a fail keyring #304

merged 1 commit into from
Nov 17, 2024

Conversation

radoering
Copy link
Member

@radoering radoering requested a review from a team November 6, 2024 16:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@abn
Copy link
Member

abn commented Nov 17, 2024

Do we have coverage elsewhere for failing keyring backends?

@radoering
Copy link
Member Author

This is poetry-plugin-export. And this is the default config fixture for all tests. I do not think that we need coverage for failing keyring backends here. I assume we just want to deactivate keyring for the tests because as we all know it can cause trouble.

I am only doing this change because we should not import keyring without declaring it as dev dependency.

@abn abn merged commit a39bc5f into python-poetry:main Nov 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abn abn abn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radoering @abn