Add --check-change option, for pre-commit export hook #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to fix python-poetry/poetry#8512 / #237.
Currently, the poetry-export pre-commit hook returns 0 even when it changes the requirements.txt file. As written here, pre-commit hooks should return a nonzero value when modifying files. This is required in order to make pipelines fail if files are not as expected - in this case, if the requirements.txt file was not updated.
I added a --check-change option, which causes
poetry export
to return 1 if it changed the output. python-poetry/poetry#8810 in the main poetry repository changes the hook to add the--check-change
option.Note: I didn't add a test yet. If you approve of the approach, I'll happily add a test.