-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reword the --with help text and deprecate --without #212
reword the --with help text and deprecate --without #212
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--without main
is still a thing, but since --with group --without main
is the same as --only group
here, there is probably no need for --without
.
specify how main can be excluded
pre-commit.ci autofix |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Quality Gate passedIssues Measures |
What is the best way to accomplish this use case? Imagine we have a pyproject.toml as follows:
How do we export requirements for main, graphql, database and in house tool groups without explicitly requesting them from
Currently, this works fine for us because we only have main and dev groups. However, if we were to add more groups there doesn't seem to be a built-in way to have all requirements except dev exported without explicitly defining them in the command. The options seem to be as follows:
|
--with is required for optional and non-optional dependencies see python-poetry/poetry-plugin-export#212 and python-poetry/poetry-plugin-export#299
--with is required for optional and non-optional dependencies see python-poetry/poetry-plugin-export#212 and python-poetry/poetry-plugin-export#299 corresponding PR in canonical/craft-parts#946
--with is required for optional and non-optional dependencies see python-poetry/poetry-plugin-export#212 and python-poetry/poetry-plugin-export#299 corresponding PR in canonical/craft-parts#946
--with is required for optional and non-optional dependencies see python-poetry/poetry-plugin-export#212 and python-poetry/poetry-plugin-export#299 corresponding PR in canonical/craft-parts#946
--with is required for optional and non-optional dependencies see python-poetry/poetry-plugin-export#212 and python-poetry/poetry-plugin-export#299 corresponding PR in canonical/craft-parts#946
This fixes #299
--with
has been updated to express that groups are never included by default--without
option has been marked deprecated since it serves no purpose anymore.Deprecation rationale:
--only
already disables--with
and--without
(ref)--without
can only remove groups that the user also provided in--with
, which means that the priority (who wins? with or without?) is an implementation detail that isn't documented.