Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capture-warnings.rst: Fix PEP number in link #13215

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

SamB
Copy link
Contributor

@SamB SamB commented Feb 10, 2025

This was linking to a completely unrelated PEP, presumably due to a typo.

Sorry there's no changelog, filing from my phone.


Thanks for submitting a PR, your contribution is really appreciated!

Here is a quick checklist that should be present in PRs.

  • Include documentation when adding new features. (Not a feature.)
  • Include new tests or update existing tests when applicable. (Testing this would be probabilistic at best.)
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

If this change fixes an issue, please:

  • Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number). See the github docs for more information. (I don't know of an issue for this.)

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) (it is) please:

- [ ] Create a new changelog file in the `changelog` folder, with a name like `..rst`. See [changelog/README.rst](https://github.com/pytest-dev/pytest/blob/main/changelog/README.rst) for details.

Write sentences in the past or present tense, examples:

  • Improved verbose diff output with sequences.
  • Terminal summary statistics now use multiple colors.

Also make sure to end the sentence with a ..

  • Add yourself to AUTHORS in alphabetical order.

This was linking to a completely unrelated PEP, presumably due to a typo.

Sorry there's no changelog, filing from my phone.
@Pierre-Sassoulas Pierre-Sassoulas added the skip news used on prs to opt out of the changelog requirement label Feb 11, 2025
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicoddemus nicoddemus merged commit f0cc122 into pytest-dev:main Feb 13, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news used on prs to opt out of the changelog requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants