Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions for stderr in capture output tests #13212

Closed
wants to merge 2 commits into from

Conversation

donBarbos
Copy link

closes #13211

@donBarbos
Copy link
Author

Maybe this change don't need changelog entry file, because changes don't have affected

@The-Compiler
Copy link
Member

I agree with what @webknjaz has said over in #13211: There is nothing printed to stderr at all, so it doesn't make sense to have an assertion on it. IMHO, following the same logic, you'd also need to use caplog and check assert not caplog.records despite the test not using logging at all.

@donBarbos
Copy link
Author

I agree with what @webknjaz has said over in #13211: There is nothing printed to stderr at all, so it doesn't make sense to have an assertion on it. IMHO, following the same logic, you'd also need to use caplog and check assert not caplog.records despite the test not using logging at all.

Ok, I got you, so I'll just close pr and issue, right?

@donBarbos donBarbos closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing assertions for stderr in capture output tests
2 participants