Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch objects pretending to be PTask. #508

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Catch objects pretending to be PTask. #508

merged 10 commits into from
Dec 1, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Dec 1, 2023

Closes #507.

@tobiasraabe tobiasraabe added this to the v0.4.3 milestone Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d846c5c) 96.50% compared to head (42f6f5e) 96.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   96.50%   96.11%   -0.40%     
==========================================
  Files         104      104              
  Lines        8917     8921       +4     
==========================================
- Hits         8605     8574      -31     
- Misses        312      347      +35     
Flag Coverage Δ
end_to_end 81.93% <100.00%> (+<0.01%) ⬆️
integration 40.23% <20.00%> (-0.03%) ⬇️
unit 68.13% <93.33%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit a06d948 into main Dec 1, 2023
@tobiasraabe tobiasraabe deleted the catch-fake-tasks branch December 1, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: fails to collect if a global variable is not __iter__able
1 participant