Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add fastanime to homies #1438

Merged
merged 1 commit into from
Oct 10, 2024
Merged

docs: add fastanime to homies #1438

merged 1 commit into from
Oct 10, 2024

Conversation

Benexl
Copy link
Contributor

@Benexl Benexl commented Oct 10, 2024

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

Adds FastAnime to homies which is just a tool that aims to replicate the anime browser site experience in the terminal.

@port19x
Copy link
Collaborator

port19x commented Oct 10, 2024

That is a pretty huge readme you got there, but decently structured at the same time.

Out of curiosity, what makes fastanime any faster than any of the other python based scrapers?

@Benexl
Copy link
Contributor Author

Benexl commented Oct 10, 2024

Well initially the name was out of spite to some guy who called my cli slow. Though eventually I did actually make it quite fast. I have implemented lazy loading of all the commands + the providers and all requests to the providers are cached to reduce repeated and often needless requests to the providers servers.

Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, your editor formatted a bunch of other stuff

@Benexl
Copy link
Contributor Author

Benexl commented Oct 10, 2024

oh no, your editor formatted a bunch of other stuff

I fixed this. It now only edits the homies section

@port19x
Copy link
Collaborator

port19x commented Oct 10, 2024

Alright, welcome to the cool kids club

@port19x port19x merged commit e448f9d into pystardust:master Oct 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants