Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1423

Closed
wants to merge 1 commit into from
Closed

Update README.md #1423

wants to merge 1 commit into from

Conversation

9e4ed328ce2e8702c291c14f2471861a-255418
Copy link
Contributor

changed a typo on line 554

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)
  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@9e4ed328ce2e8702c291c14f2471861a-255418
Update README.md
9000a13 
changed a typo on line 554
@Nannk
Copy link
Contributor

Nannk commented Sep 17, 2024 •
edited
Loading

Isn't this PR the same as #1422?

@port19x
Copy link
Collaborator

port19x commented Sep 19, 2024

It is! Nice catch Nannk

@port19x port19x closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justchokingaround justchokingaround Awaiting requested review from justchokingaround justchokingaround is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9e4ed328ce2e8702c291c14f2471861a-255418 @Nannk @port19x