Deprecate tools.setuptools.license-files #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
force-pushed
the
639-deprecated-setuptools.license-files
branch
from
6dee35f to
ab277d3
Compare
abravalheri
reviewed
Feb 18, 2025
abravalheri
reviewed
Feb 18, 2025
docs/userguide/pyproject_config.rst
Outdated
| @@ -99,7 +99,7 @@ Key Value Type (TOML) Notes | |||
| See :doc:`/userguide/datafiles`. | |||
| ``exclude-package-data`` table/inline-table Empty by default. See :doc:`/userguide/datafiles`. | |||
| ------------------------- --------------------------- ------------------------- | |||
| ``license-files`` array of glob patterns **Provisional** - likely to change with :pep:`639` | |||
| ``license-files`` array of glob patterns **Deprecated** - use ``project.license-files`` instead. See :doc:`PyPUG:guides/writing-pyproject-toml/#license-files` | |||
There was a problem hiding this comment.
I notice that sphinx is issuing the following warning:
/home/runner/work/setuptools/setuptools/docs/userguide/pyproject_config.rst:103: WARNING: unknown document: 'PyPUG:guides/writing-pyproject-toml/#license-files' [ref.doc]
There was a problem hiding this comment.
Seems the anchor link doesn't exist. Opened pypa/packaging.python.org#1816 upstream and used the generic link here so it doesn't block the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
tools.setuptools.license-filesin favor ofproject.license-files.Ref #4829
/CC @abravalheri