Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLflow callback logging #1425

Merged
merged 4 commits into from
Jan 23, 2025
Merged

MLflow callback logging #1425

merged 4 commits into from
Jan 23, 2025

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jan 23, 2025

Description

Add a callback that works with the "pymc" nuts sampler

tracking

Related Issue

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1425.org.readthedocs.build/en/1425/

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (2ef7b51) to head (153bf6f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1425      +/-   ##
==========================================
+ Coverage   94.59%   94.62%   +0.02%     
==========================================
  Files          50       50              
  Lines        5388     5416      +28     
==========================================
+ Hits         5097     5125      +28     
  Misses        291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622 wd60622 added the enhancement New feature or request label Jan 23, 2025
Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! 🚀 . How ward is to do this for other samplers like nutpie or numpyro?

@juanitorduz juanitorduz merged commit d9f0c51 into main Jan 23, 2025
20 checks passed
@juanitorduz juanitorduz deleted the mlflow-logging-callback branch January 23, 2025 16:01
@wd60622
Copy link
Contributor Author

wd60622 commented Jan 23, 2025

I love this! 🚀 . How ward is to do this for other samplers like nutpie or numpyro?

Both need a bit of work. However, there are some conversation happening!

Numpyro status: https://forum.pyro.ai/t/is-callback-supported-for-numpyro-nuts-sampler/6308?u=alfredo_delgado
Nutpie conversation starting here: pymc-devs/nutpie#166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mlflow tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants