Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BetaGeoModel to BetaGeoNBDModel? #1403

Open
ColtAllen opened this issue Jan 18, 2025 · 1 comment
Open

Rename BetaGeoModel to BetaGeoNBDModel? #1403

ColtAllen opened this issue Jan 18, 2025 · 1 comment
Labels
CLV good second issue Bit more involved but still doable for newcomers major API breaking changes priority: low request discussion

Comments

@ColtAllen
Copy link
Collaborator

This would obviously be a massive API-breaking change, but BG/NBD is the correct name for this model. The BG model itself is very similar to the existing ShiftedBetaGeoModelIndividual and pertains to subscription renewals rather than retail transactions.
@ColtAllen ColtAllen added CLV good second issue Bit more involved but still doable for newcomers major API breaking changes priority: low request discussion labels Jan 18, 2025
@wd60622
Copy link
Contributor

wd60622 commented Jan 18, 2025

There was similar API change from the DelayedSaturatedMMM -> MMM. Same 2 version deprecation. Just keep previous class name which initialized other class / throw deprecation warning.

I am for the change. Seems like a clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLV good second issue Bit more involved but still doable for newcomers major API breaking changes priority: low request discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ColtAllen @wd60622