-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute pushforward (Rop) via double application of pullback (Lop) and fix Scan and Max gradient bugs #1207
Conversation
0836022
to
9221d2e
Compare
9e640a6
to
03e29d2
Compare
03e29d2
to
2798a6e
Compare
float32 tests fail, shocker... |
2798a6e
to
0b64124
Compare
a31d5a6
to
8031d33
Compare
8031d33
to
77e2581
Compare
Also fixes bug in Scan L_op and Max R_op Co-authored-by: Adrian Seyboldt <aseyboldt@users.noreply.github.com>
77e2581
to
4136161
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (85.07%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
+ Coverage 82.25% 82.28% +0.03%
==========================================
Files 186 186
Lines 47981 47987 +6
Branches 8630 8629 -1
==========================================
+ Hits 39465 39486 +21
+ Misses 6356 6347 -9
+ Partials 2160 2154 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :-)
Extracted this from #788 as it's a pretty nice feature to have. This should allow Rop of basically any graph, whereas the specialized support of Rop was pretty patchy.
Also fixes bugs in Scan L_op and Max R_op revealed by the changes / new tests.
Related to #182
Closes #6
Not using the new grad names yet on user facing functions and docs, let's do that for the next major release
📚 Documentation preview 📚: https://pytensor--1207.org.readthedocs.build/en/1207/