Ignore named variables that are not traceable in `get_vars_in_point_l…

…ist`
pymc-devs · May 30, 2023 · b17a60d · b17a60d
1 parent fbc62d5
commit b17a60d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/pymc/sampling/forward.py b/pymc/sampling/forward.py
@@ -89,7 +89,8 @@ def get_vars_in_point_list(trace, model):
         names_in_trace = list(trace[0])
     else:
         names_in_trace = trace.varnames
-    vars_in_trace = [model[v] for v in names_in_trace if v in model]
+    traceable_varnames = {var.name for var in (model.free_RVs + model.deterministics)}
+    vars_in_trace = [model[v] for v in names_in_trace if v in traceable_varnames]
     return vars_in_trace
 
 

diff --git a/tests/sampling/test_forward.py b/tests/sampling/test_forward.py
@@ -1634,11 +1634,13 @@ def test_get_vars_in_point_list():
     with pm.Model() as modelA:
         pm.Normal("a", 0, 1)
         pm.Normal("b", 0, 1)
+        pm.Normal("d", 0, 1)
     with pm.Model() as modelB:
         a = pm.Normal("a", 0, 1)
         pm.Normal("c", 0, 1)
+        pm.ConstantData("d", 0)
 
-    point_list = [{"a": 0, "b": 0}]
+    point_list = [{"a": 0, "b": 0, "d": 0}]
     vars_in_trace = get_vars_in_point_list(point_list, modelB)
     assert set(vars_in_trace) == {a}