-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
@samwaseda You also have to update the damask version in https://github.com/pyiron/pyiron_continuum/blob/main/.ci_support/environment-notebooks.yml |
Hi all, I think this should also be considered for the 'import': 6e2ff04. The |
Hm I don't quite understand why the tests are failing |
(no idea if its correct)
Ok now I understood that there's a conflict between fenics and damask, and I didn't see the problem on my local installation because I don't have fenics. Do you want to take a look? @mbruns91 |
Apparently, the environment created from |
33efd82
to
95e0249
Compare
(writing all of this down here, kind of serves as a reminder for me, as I won't be able to work continuously on this today) Next step would be to run integration tests now seperately for the damask- and the fenics-based notebooks. This requires changes to some files in I think this makes sense, as we can then at least guarantee, that a user wanting to run fenics/damask only, can be sure that works. Having access to both from the same environment will, however, not be supported at this point. |
Ok, that was unsuccessful. the changes from my commits need to be merged into main first for the ci to change. I'll open another branch and PR for that. |
2588585
to
3ce5a20
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
From the recent development in DAMASK it looked to me like the names had to be changed this way