Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

[Damask] update import names #256

Merged
merged 11 commits into from
Apr 10, 2024
Merged

[Damask] update import names #256

merged 11 commits into from
Apr 10, 2024

Conversation

samwaseda
Copy link
Member

@samwaseda samwaseda commented Mar 15, 2024

From the recent development in DAMASK it looked to me like the names had to be changed this way

@samwaseda samwaseda added the bug Something isn't working label Mar 15, 2024
@samwaseda samwaseda requested a review from yangbai90 March 15, 2024 10:19
@samwaseda samwaseda linked an issue Mar 15, 2024 that may be closed by this pull request
@jan-janssen
Copy link
Member

@samwaseda You also have to update the damask version in https://github.com/pyiron/pyiron_continuum/blob/main/.ci_support/environment-notebooks.yml

@yangbai90
Copy link
Contributor

Hi all, I think this should also be considered for the 'import': 6e2ff04. The imp is not necessary anymore, maybe we could remove it.

@samwaseda
Copy link
Member Author

Hm I don't quite understand why the tests are failing

@samwaseda
Copy link
Member Author

Ok now I understood that there's a conflict between fenics and damask, and I didn't see the problem on my local installation because I don't have fenics. Do you want to take a look? @mbruns91

@mbruns91
Copy link
Contributor

Apparently, the environment created from .ci_support/environment-notebooks.yml cannot be solved, as the requirements imposed by packages damask and fenics are incompatibel. I'll follow a suggestion from @samwaseda and split this file into one for the the damask and another for the fencis notebooks.

@mbruns91
Copy link
Contributor

mbruns91 commented Mar 20, 2024

(writing all of this down here, kind of serves as a reminder for me, as I won't be able to work continuously on this today)

Next step would be to run integration tests now seperately for the damask- and the fenics-based notebooks. This requires changes to some files in .github/workflows/ and also to .ci_support/build_notebooks.sh and some more.

I think this makes sense, as we can then at least guarantee, that a user wanting to run fenics/damask only, can be sure that works. Having access to both from the same environment will, however, not be supported at this point.

@mbruns91
Copy link
Contributor

Ok, that was unsuccessful. the changes from my commits need to be merged into main first for the ci to change. I'll open another branch and PR for that.

@samwaseda samwaseda changed the base branch from main to update_ci March 21, 2024 13:48
Base automatically changed from update_ci to main April 10, 2024 10:22
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@samwaseda samwaseda merged commit 8d92388 into main Apr 10, 2024
11 checks passed
@samwaseda samwaseda deleted the damask_imports branch April 10, 2024 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Damask import fails
4 participants