-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TokenGT model #9834
base: master
Are you sure you want to change the base?
Add TokenGT model #9834
Conversation
@wsad1 @EdisonLeeeee @akihironitta any thoughts on when this contribution will get reviewed? :) |
@michailmelonas this is cool, ill review and help merge soon as my time allows, |
this looks good, will do a deep review soon |
this is good at a high level. however i want to see how it compares to existing work. Can you please update this example: |
@puririshi98 sure thing, will do asap. |
@michailmelonas lmk when ready for further review |
@puririshi98 apologies for only getting back to you now - have been swamped at work.
|
i think as a sanity check to get this merged, you should make an example which uses some opensource dataset(check relbench or ogb) to show higher accuracy than gcn and sage (with an argparser to choose between the three, defaulting to your graphtransformer). it will be a good research experience for you |
Okay, will do. Will most likely only get to this next week. Apologies that this is dragging. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9834 +/- ##
==========================================
- Coverage 86.79% 86.39% -0.41%
==========================================
Files 490 492 +2
Lines 32436 32594 +158
==========================================
+ Hits 28154 28159 +5
- Misses 4282 4435 +153 ☔ View full report in Codecov by Sentry. |
no problem, looking forward to seeing what you can do :) |
checking in @michailmelonas hows it going? |
please ensure you follow this |
@puririshi98 really sorry for the late response - between coursework (https://web.stanford.edu/class/cs234/) and working full time I've not had a chance to get to this. I think the PCQM4Mv2 dataset (https://ogb.stanford.edu/docs/lsc/pcqm4mv2/) would be best to benchmark |
PyG implementation of the Tokenized Graph Transformer following "Pure Transformers are Powerful Graph Learners" (https://arxiv.org/pdf/2207.02505). Includes support for both Laplacian eigenvectors and ORF node identifiers (implemented via a simple data Transform object). A graph regression example is also included.
For a detailed blog post about the implementation, see https://medium.com/stanford-cs224w/pyg-implementation-tokengt-e4aa74dc867b.