-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add torch_geometric.nn.attention
to docs
#10089
base: master
Are you sure you want to change the base?
Conversation
xnuohz
commented
Mar 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Could we have a similar list to the list of conv layers?
Convolutional Layers
--------------------
.. currentmodule:: torch_geometric.nn.conv
.. autosummary::
:nosignatures:
:toctree: ../generated
:template: autosummary/nn.rst
{% for name in torch_geometric.nn.conv.classes %}
{{ name }}
{% endfor %}
there are too many conv modules, if list all the details, i think searching will be inconvenient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdym? nn.attention
has 4 layers:
$ git grep "class " torch_geometric/nn/attention/
torch_geometric/nn/attention/performer.py:class PerformerProjection(torch.nn.Module):
torch_geometric/nn/attention/performer.py:class PerformerAttention(torch.nn.Module):
torch_geometric/nn/attention/qformer.py:class QFormer(torch.nn.Module):
torch_geometric/nn/attention/sgformer.py:class SGFormerAttention(torch.nn.Module):
misread it to expand all the conv modules haha |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10089 +/- ##
==========================================
- Coverage 86.74% 86.29% -0.46%
==========================================
Files 493 493
Lines 33069 33079 +10
==========================================
- Hits 28685 28544 -141
- Misses 4384 4535 +151 ☔ View full report in Codecov by Sentry. |