Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch_geometric.nn.attention to docs #10089

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xnuohz
Copy link
Contributor

@xnuohz xnuohz commented Mar 1, 2025

image

Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could we have a similar list to the list of conv layers?

Convolutional Layers
--------------------

.. currentmodule:: torch_geometric.nn.conv

.. autosummary::
   :nosignatures:
   :toctree: ../generated
   :template: autosummary/nn.rst

   {% for name in torch_geometric.nn.conv.classes %}
     {{ name }}
   {% endfor %}

@xnuohz
Copy link
Contributor Author

xnuohz commented Mar 1, 2025

there are too many conv modules, if list all the details, i think searching will be inconvenient.

Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdym? nn.attention has 4 layers:

$ git grep "class " torch_geometric/nn/attention/
torch_geometric/nn/attention/performer.py:class PerformerProjection(torch.nn.Module):
torch_geometric/nn/attention/performer.py:class PerformerAttention(torch.nn.Module):
torch_geometric/nn/attention/qformer.py:class QFormer(torch.nn.Module):
torch_geometric/nn/attention/sgformer.py:class SGFormerAttention(torch.nn.Module):

@xnuohz
Copy link
Contributor Author

xnuohz commented Mar 1, 2025

misread it to expand all the conv modules haha

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (3f2f43d) to head (904212b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10089      +/-   ##
==========================================
- Coverage   86.74%   86.29%   -0.46%     
==========================================
  Files         493      493              
  Lines       33069    33079      +10     
==========================================
- Hits        28685    28544     -141     
- Misses       4384     4535     +151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants