Support saving/loading of GBDT models #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 93.20% 93.25% +0.04%
==========================================
Files 115 115
Lines 5680 5719 +39
==========================================
+ Hits 5294 5333 +39
Misses 386 386 ☔ View full report in Codecov by Sentry. |
weihua916
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Thanks! Can you please add tests for loading/saving? You can follow https://github.com/pyg-team/pytorch-frame/blob/master/test/utils/test_io.py#L14-L16
|
@weihua916 Add a test case for it. Is it correct? |
weihua916
reviewed
Dec 6, 2023
weihua916
reviewed
Dec 6, 2023
yiweny
reviewed
Dec 6, 2023
|
@weihua916 @yiweny Done. (Bad network, took some time to install mypy lol) |
yiweny
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM after resolving the comment. Let's merge after a pass from @weihua916
weihua916
reviewed
Dec 8, 2023
for more information, see https://pre-commit.ci
… into gbdts/save-and-load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#242