Raise value error when numerical columns contain other dtypes #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 93.28% 93.29% +0.01%
==========================================
Files 115 115
Lines 5632 5641 +9
==========================================
+ Hits 5254 5263 +9
Misses 378 378 ☔ View full report in Codecov by Sentry. |
|
Should we raise an informative error instead? |
yiweny
changed the title
weihua916
reviewed
Dec 4, 2023
weihua916
approved these changes
Dec 4, 2023
akihironitta
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit the bug when running
california_house_pricedataset intransformers_text.py.I think this is because some values are numbers, others are strings, e.g.
One guest bedroometc. So the series gets interpreted as<U262dtype.