Fix typing in torch_frame/data/tensor_frame.py
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
commented
Dec 2, 2023
yiweny
reviewed
Dec 2, 2023
akihironitta
commented
Dec 2, 2023
Co-authored-by: Yiwen Yuan <yyuanlisette@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 93.29% 93.31% +0.01%
==========================================
Files 115 115
Lines 5655 5668 +13
==========================================
+ Hits 5276 5289 +13
Misses 379 379 ☔ View full report in Codecov by Sentry. |
weihua916
approved these changes
Dec 3, 2023
…into aki/type1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #261.
Fix typing of
TensorFrame. No need for a changelog entry as it doesn't impact users.