Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed text_tokenized_cfg into col_to_text_tokenized_cfg #257

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Renamed text_tokenized_cfg into col_to_text_tokenized_cfg #257

merged 4 commits into from
Dec 4, 2023

Conversation

zechengz
Copy link
Member

@zechengz zechengz commented Dec 2, 2023 •
edited
Loading

Renamed text_tokenized_cfg into col_to_text_tokenized_cfg

@zechengz zechengz requested a review from weihua916 December 2, 2023 00:09
@zechengz zechengz self-assigned this Dec 2, 2023
@zechengz zechengz changed the title Dictionary of text_tokenized_cfg Renamed text_tokenized_cfg into col_to_text_tokenized_cfg Dec 2, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fffd624) 93.17% compared to head (00a08e5) 93.18%.

Files Patch % Lines
torch_frame/data/dataset.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   93.17%   93.18%           
=======================================
  Files         115      115           
  Lines        5659     5662    +3     
=======================================
+ Hits         5273     5276    +3     
  Misses        386      386

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zechengz zechengz marked this pull request as ready for review December 2, 2023 00:15
weihua916
weihua916 approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@weihua916 weihua916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weihua916
Copy link
Contributor

The next step is to edit LinearModelEncoder and replace the current model into col_to_model?

Also please do not forget to update example and tutorial documentation accordingly. Thanks!

@zechengz
Copy link
Member Author

zechengz commented Dec 3, 2023

@weihua916 Sure, will merge this PR first and then LinearModelEncoder and documentation.

@zechengz zechengz merged commit 9c6ac22 into master Dec 4, 2023
10 checks passed
@zechengz zechengz deleted the zecheng_multi_text_tokenized_cfg branch December 4, 2023 00:03
@weihua916
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihua916 weihua916 weihua916 approved these changes

Assignees

@zechengz zechengz

Labels
data dataset example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zechengz @weihua916