modified: README.md

	modified:   sendit/apps/main/tasks.py

README.md

@@ -228,3 +228,5 @@ Generally, the query of interest will retrieve a set of images with an associate
 
 # Questions
  - Given no errors for a batch, we will be cleaning up the database and the media files, which means complete deletion. Is there any desire for a log to be maintained somewhere, and if so, where? Right now, the logs that we have are for the watcher, that logs the name of the folders and when they are complete. If we want more logging, for what actions, under what circumstances?
+ - For de-identification, we have the option to remove private tags (`dicom.remove_private_tags()`), which are those that have been added to the dataset (but don't conform to the standard). If we don't remove them, they will be blanked. Should we remove? Is there reason they would have private tags?
+ - Can the API take / respond with lists of {'identifiers'} objects, each with an id, id_source, associated items? If not, I can handle the need internally with the client (eg, we are passing around generally groups of these things, but (I think) the API is set up to handle single objects. I don't want to place the burden of unwrapping a list (and then rewrapping) on the client.

sendit/apps/main/tasks.py

@@ -171,13 +171,14 @@ def get_identifiers(bid,study=None):
         ids = get_ids(dicom_files=dicom_files)
 
         # This should only be for one loop, given a folder with one patient
-        deids = dict()
+        deids = []
 
         # NOTE: if the API is allowed to take a list, we don't need to do this.
         for uid,identifiers in ids.items():
             bot.debug("som.client making request to deidentify %s" %(uid))
-            deids.append(cli.deidentify(ids=identifiers,
-                                        study=study))
+            result = cli.deidentify(ids=identifiers,
+                                    study=study)     # should be a list
+            deids = deids + result
 
         batch_ids = BatchIdentifiers.objects.create(batch=batch,
                                                     response=deids)